Skip to content

Fixed: errno update failure with IAR8.x #5525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

deepikabhavnani
Copy link

Setting errno (part of thread local storage) caused hardfault with IAR8.x versions. TLS is not supported, hence using main thread TLS area for all threads.

errno (part of thread local storage) setting caused hardfault with IAR8.x
versions. TLS is not supported, hence using main thread TLS area for
all threads.
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2017

Build : SUCCESS

Build number : 550
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5525/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2017

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2017

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2017

one more time

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2017

@deepakvenugopal Just to confirm. this goes to master branch, not iar 8 feature ? This has been tested with IAR 7.8. Was this an intention?

@deepikabhavnani
Copy link
Author

Yes fix is on master branch for existing support of IAR, function updated is not called for IAR 7.8.

#if defined(IAR_SYSTEMS_ICC ) && (VER >= 8000000)’

@deepikabhavnani
Copy link
Author

Testing with IAR7.8 is mandatory since we support that. But the fix is for IAR 8.x so it will be good to have CI run with IAR8 as well.
But none of our test, check/set errno implicitly so I am not sure if this code will be touched in testing.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2017

I was thinking if this should not be send to IAR8 branch, to be a bugfix. This does not affect master anyhow (as you stated above), would be tested with proper version and would end up on master once IAR8 feature branch gets integrated. However, I see it now that it's already protected with IAR8 version plus it's on master, fine as it is.

@deepikabhavnani
Copy link
Author

@0xc0170 - mbed-os 5.6 supports IAR 8.x, hence fix was applied to master. Its not breaking change for IAR 7.8, only breaking changes like libraries and dynamic heap are on feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants