-
Notifications
You must be signed in to change notification settings - Fork 3k
Fixed: errno update failure with IAR8.x #5525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
errno (part of thread local storage) setting caused hardfault with IAR8.x versions. TLS is not supported, hence using main thread TLS area for all threads.
/morph build |
Build : SUCCESSBuild number : 550 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 165 |
Test : FAILUREBuild number : 360 |
/morph test |
Test : SUCCESSBuild number : 364 |
one more time /morph test |
Test : SUCCESSBuild number : 381 |
@deepakvenugopal Just to confirm. this goes to master branch, not iar 8 feature ? This has been tested with IAR 7.8. Was this an intention? |
Yes fix is on master branch for existing support of IAR, function updated is not called for IAR 7.8. |
Testing with IAR7.8 is mandatory since we support that. But the fix is for IAR 8.x so it will be good to have CI run with IAR8 as well. |
I was thinking if this should not be send to IAR8 branch, to be a bugfix. This does not affect master anyhow (as you stated above), would be tested with proper version and would end up on master once IAR8 feature branch gets integrated. However, I see it now that it's already protected with IAR8 version plus it's on master, fine as it is. |
@0xc0170 - mbed-os 5.6 supports IAR 8.x, hence fix was applied to master. Its not breaking change for IAR 7.8, only breaking changes like libraries and dynamic heap are on feature branch. |
Setting errno (part of thread local storage) caused hardfault with IAR8.x versions. TLS is not supported, hence using main thread TLS area for all threads.